This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Compatible springboot3 #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 1, 2023 11:58
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage 67.67% 67.67%
Complexity 296 296
=========================================
Files 75 75
Lines 1680 1680
Branches 108 108
=========================================
Hits 1137 1137
Misses 470 470
Partials 73 73 ☔ View full report in Codecov by Sentry. |
lvjing2
reviewed
Nov 3, 2023
| @@ -0,0 +1,34 @@ | |||
| ## SOFAServerless 支持中间件列表与样例 | |||
|
|
||
| ### 支持 Java EE/Jakarta EE | ||
| 随着 Oracle 将 Java EE 交给 Eclipse 开始 Java EE 就成为了历史，取而代之的是新的 Jakarta EE 系列。对于开发者而言，最大的改变便是从 jakarta EE 9 开始， EE 相关的类的命名空间从 javax.* 迁移到了 jakarta.*。 | ||
| 对于这一变更，开源社区的组件也均在不同进度的进行升级适配：例如 Tomcat 从 10.x 版本开始便迁移到了 jakarta 命名空间。而 SpringBoot 3.x 版本也不再支持 Java EE 8，而是基于 Jakarta EE 9 构建。 为了支持 Jakarta EE，sofa-ark 将从 2.2.4 开始发布后缀为 `-jakarta`的包。 |
There was a problem hiding this comment.
这里说明下 sofaArk 是同时发布 带和不带 '-jakarta' 的两个版本，说明使用的不同场景，并这段也需要补充到 sofaArk 官网里。
There was a problem hiding this comment.
被上sofa-serverless-base-starter 包含掉了, 就不需要说明了
| <dependency> | ||
| <groupId>com.alipay.sofa</groupId> | ||
| <artifactId>sofa-ark-support-starter</artifactId> | ||
| <version>2.2.4-SNAPSHOT</version> |
| @@ -312,8 +312,12 @@ private LoggerConfiguration convertLoggerConfig(String name, LoggerConfig logger | |||
|
|
|||
| @Override | |||
| public void cleanUp() { | |||
| if (isBridgeHandlerAvailable()) { | |||
| removeJdkLoggingBridgeHandler(); | |||
| try { | |||
There was a problem hiding this comment.
确保 jdk8 单测运行正常的情况下，补充下 jdk 17 的单测。
There was a problem hiding this comment.
没有额外修改, 直接try catch了
added 12 commits
November 3, 2023 16:34
…mpatible-springboot3
yuanyuancin
reviewed
Nov 6, 2023
| @@ -0,0 +1 @@ | |||
| com.alipay.sofa.serverless.log4j2.SOFAServerlessLog4j2SpringContextListener | |||
There was a problem hiding this comment.
listener也是通过AutoConfiguration.imports文件声明的？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
compatible-springboot3 and add examples
Modification
Describe the idea and modifications you've done.
Result
Resolved or fixed #.
If there is no issue then describe the changes introduced by this PR.