Skip to content

allows [Object: null prototype] in binary packet #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

allows [Object: null prototype] in binary packet #114

merged 1 commit into from
Feb 17, 2022

Conversation

Gabba90
Copy link
Contributor

@Gabba90 Gabba90 commented Feb 9, 2022

Hello,

I get the following error when trying to encode a binary packet with a null prototype object:

socketio_parser_error

I think the solutions is to simply use the safer version of the call to hasOwnProperty, just like here.

Let me know what you think of it.

@darrachequesne darrachequesne merged commit 7f6b262 into socketio:master Feb 17, 2022
@darrachequesne
Copy link
Member

@Gabba90 thanks! 👍

@darrachequesne darrachequesne added this to the 4.1.2 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabba90 @darrachequesne