Switch to xmpp.js #353
Merged
Switch to xmpp.js #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functionality for joining a room and receiving chat messages
* switch to jest, move code to src * stanzas for the actions we currently support * coverage for functions which use xmpp.js added * lower coverage threshold for now
* stanzas for the actions we currently support * switch to jest, move code to src * remove simple-xmpp handlers, stanza is public * remove old test directory, implement new incoming-handlers.test.js and improve structure for clarity * set thresholds Co-authored-by: Garret Alfert <alfert@wevelop.de> * Update packages/sockethub-platform-xmpp/src/index.test.js Co-authored-by: Garret Alfert <alfert@wevelop.de> * consolidate chat message handler, improve tests and use displayName prop Co-authored-by: Garret Alfert <alfert@wevelop.de>
raucao
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Code LGTM. And I tested successfully with 2 XMPP accounts in Hyperchannel.
There are some warnings on startup, but not sure if they are new:
(node:137736) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:137736) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:137736) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:137736) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:137736) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:137736) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
|
Please manually kredit me a medium for pairing, when this is merged. I didn't help enough for assigning myself to the PR as well. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the entire
xmppplatform from a hybrid ofnode-xmppandnode-simple-xmpptoxmpp.js, adds unit tests for the platform improving on the coverage and switching tojestfromjaribu. This doesn't add any new XMPP functionality but replaces what was already there before with the improved code.