I just tried to validate this fix. But both on the master branch, as well as this one, I get CORS errors from trying to connect to Sockethub from Hyperchannel (master) in the first place:

I think it shouldn't even use HTTP polling in the first place, so there seems to be something wrong with the connection itself.

Same in both Firefox and Chromium for me. Sockethub client doesn't try to connect via Websockets at all, and fails to connect due to missing CORS headers when falling back to HTTP polling.

Edit: I also have a massive diff on yarn lock files (4553 lines) after running npm i (i.e. lerna bootstrap). But it looks like it's just re-ordering properties in the objects of all package dependencies' metadata...

I just ran yarn install and then DEBUG=sockethub* yarn run dev from the project root.

I also see large diffs for yarn lock files in the root and in packages/sockethub-platform-irc/.

But everything works for me with both Chrome and Firefox.

When I quit the Sockethub server while Hyperchannel is still running, I can see the same error messages as you. So my guess would be that Sockethub didn't start properly for you.

So my guess would be that Sockethub didn't start properly for you.

Looks alright to me:

Yes, that looks pretty much the same as here.

Can you open http://localhost:10550/ in the browser?

Can you open http://localhost:10550/ in the browser?

Aha: those examples work just fine, using Websockets immediately! Anything not on he same origin doesn't seem to attempt Websockets and fails at HTTP polling with the CORS errors.

@raucao Hmm.. Are both Hyperchannel and Sockethub running on localhost? Becuase if I do that they work fine, but I do get weirdness if they are running on different "hosts" eg local.dev and localhost or some variant like that. localhost + CORS is treated with suspicion by the browser in some cases that wouldn't ordinarily be the case on two different hosts neither of which are localhost..

Merging now and will followup with @raucao as it's not related to this PR.