Skip to content

Use relative path for process forking #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

Use relative path for process forking #276

merged 1 commit into from
Sep 8, 2020

Conversation

galfert
Copy link
Contributor

@galfert galfert commented Jul 30, 2020

Fixes #255

When installing Sockethub as a dependency of another project and then trying to run it from there, an error is thrown:

Error: Cannot find module '/Users/galfert/code/active/kosmos/hyperchannel/dist/platform.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1030:15)
    at Function.Module._load (internal/modules/cjs/loader.js:899:27)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

This fixes that error.

@galfert
Use relative path for process forking
3f2ba07 
Fixes #255

This fixes an error (`MODULE_NOT_FOUND`) when running Sockethub as a dependency of another project.
@galfert galfert added kredits-2 Medium contribution kredits-1 Small contribution and removed kredits-2 Medium contribution labels Jul 30, 2020
@silverbucket silverbucket self-requested a review September 8, 2020 16:32
@silverbucket silverbucket merged commit e219c4e into master Sep 8, 2020
@galfert galfert deleted the bugfix/255-fix_relative_path branch September 8, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverbucket silverbucket Awaiting requested review from silverbucket

Assignees
No one assigned
Labels
kredits-1 Small contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies missing when running sockethub as dependency
2 participants
@galfert @silverbucket