Skip to content

Fix/update Docker setup #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Conversation

Cobertos
Copy link
Contributor

@Cobertos Cobertos commented Aug 21, 2021

Not completed yet, need to rewrite the parts that I wrote with yarn still
Should be good now

closes #511

@Cobertos
Copy link
Contributor Author

image
Looks to be working now with yarn

I didn't do any build size optimization for this. Let me know if that's needed.

@raucao raucao changed the title Fixes Docker setup (sockethub#511) Fix/update Docker setup Aug 21, 2021
@silverbucket
Copy link
Member

Thanks @Cobertos, this LGTM!

I didn't do any build size optimization for this. Let me know if that's needed.

I don't think it's anything to worry about for now, we can always optimize later.

@silverbucket silverbucket self-requested a review August 25, 2021 16:46
@silverbucket
Copy link
Member

BTW @Cobertos - @raucao added your account to our kredits ecosystem for contributors, so you can receive kredits!

All PRs take a kredits-* label (kredits-1 for minor, kredits-2 for medium, kredits-3 for an insane amount of work) which will be tied to the assignee of the PR. Reviewers also get a smaller fraction of kredits in relation to the label.

You can check it out at https://kredits.kosmos.org/dashboard and read more about Kredits at https://wiki.kosmos.org/Kredits ... feel free to let us know if you have any questions or comments.

@silverbucket silverbucket merged commit 2ad2bf9 into sockethub:master Aug 25, 2021
@silverbucket silverbucket added kredits-2 Medium contribution and removed kredits-1 Small contribution labels Aug 25, 2021
silverbucket added a commit that referenced this pull request Aug 25, 2021
* Dockerfile and docker-compose changes (#511)

Co-authored-by: Nick Jennings <nick@silverbucket.net>
@Cobertos
Copy link
Contributor Author

Cobertos commented Sep 12, 2021

I ended up switching to Matrix for the client work I was working on (instead of IRC) so ended up switching off Sockethub.

But thanks for the add!

EDIT: Also tried tipping but I don't host a lightning node (and haven't done much with crypto since 2016) and tippin.me seems to be not accepting new signups 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couple issues with docker-compose setup
2 participants