Skip to content

Keep client event handlers stored in an array #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2021
Merged

Keep client event handlers stored in an array #522

merged 3 commits into from
Aug 18, 2021

Conversation

silverbucket
Copy link
Member

@silverbucket silverbucket commented Aug 16, 2021 •
edited by raucao
Loading

Allows for multiple handlers to be registered for the special on events that sockethub-client needs to intercept. Resolves #495

@silverbucket silverbucket added this to the Core milestone Aug 16, 2021
@silverbucket silverbucket requested a review from raucao August 16, 2021 20:12
@silverbucket silverbucket self-assigned this Aug 16, 2021
raucao
raucao reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@raucao raucao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 👏

Just a syntax nitpick for now (which your text editor should actually warn about, if it's linting the source code live). Have yet to test it with running code.

@silverbucket silverbucket mentioned this pull request Aug 17, 2021
Closed
@silverbucket
Copy link
Member Author

I've done some manual testing, but not extensively. I don't have any unit tests set up for this JS file, but plan to add integration tests which would register multiple handlers, etc. (Once that branch work is complete). Created issue: #525

@silverbucket silverbucket requested a review from raucao August 17, 2021 09:35
@raucao
Copy link
Contributor

raucao commented Aug 17, 2021 •
edited
Loading

Just one question, as I was looking at it: did you consider removeListener() / off() to work with this? Because that's actually what we need in Hyperchannel, too.

@silverbucket
Copy link
Member Author

@raucao that's not implemented, I'm thinking maybe this would be better to include an actual event emitter which proxies for the socket even emitter, rather than a makeshift one. It would need to basically be re-written though. Maybe this could be a temporary fix for the specific issue with a new task to re-write the whole thing?

raucao
raucao approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@raucao raucao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do it as you propose. I was able to test this one with Hyperchannel successfully (albeit the channel join failures directly after the connect still persist, so that's a different issue in the XMPP platform itself).

@silverbucket
Copy link
Member Author

Created #526

@silverbucket silverbucket merged commit 3fc5585 into master Aug 18, 2021
@silverbucket silverbucket deleted the sockethub-client-listeners branch August 18, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raucao raucao raucao approved these changes

Assignees

@silverbucket silverbucket

Labels
kredits-1 Small contribution state:ready type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sockethub-client overwriting socket.on with a version that doesn't support multiple listeners
2 participants
@silverbucket @raucao