-
Notifications
You must be signed in to change notification settings - Fork 43
Add route to generated source map for sockethub-client #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks llike there's a URL mismatch still (check the filename):
Source map error: Error: request failed with status 404
Resource URL: http://localhost:10550/sockethub-client.js
Source Map URL: client.js.map
@raucao OK, it's a bit of a hack but it should work now. I was able to strip away full path references, but have been unable to remove relative paths. So it specifies the path as |
I'm not sure what you're testing this with, but I still get the error:
Do you not see the same? If you use Chrome, then it looks like this for example:
|
Weird, no I don't get this - I get the "Source Map Detected" alert in the devtools when inspecting the code for sockethub-client.js |
@raucao make sure you rm -rf packages/sockethub/dist first - there could be leftover files in there. |
@raucao any update on this? Making sure the old build files are gone should be the fix, because your error is referencing things that don't exist anymore. (client.js is no longer a file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha: it seems I ran start
instead of dev
, thus using the old build. Sorry! I see it working now. 👍
Resolves #486
@raucao can you verify this works for you?