Skip to content

Feeds: Fix results not being sent back correctly #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

silverbucket
Copy link
Member

@silverbucket silverbucket commented Aug 15, 2021

Fixes bug where results where not being propagated back to the client for non persistent platforms (eg. platforms which are shared between any number of users, contain no user-specific info, and can only send data to users as a response to a request).

Depends on #517 to be merged first.

@silverbucket silverbucket added this to the Feeds Platform milestone Aug 15, 2021
@silverbucket silverbucket self-assigned this Aug 15, 2021
@silverbucket silverbucket added the kredits-1 Small contribution label Aug 15, 2021
@silverbucket silverbucket changed the base branch from socketio-middleware-callbacks to master August 15, 2021 11:31
@silverbucket silverbucket changed the base branch from master to socketio-middleware-callbacks August 15, 2021 11:31
@lgtm-com
Copy link

lgtm-com bot commented Aug 15, 2021

This pull request introduces 1 alert when merging 2ff463f into 3080cf5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@silverbucket silverbucket requested review from galfert and raucao August 16, 2021 18:11
@raucao raucao changed the title Feeds: Results were not being sent back correctly Feeds: Fix results not being sent back correctly Aug 17, 2021
@silverbucket
Copy link
Member Author

@raucao @galfert - this is ready for review as well, can be merged after #517

Copy link
Contributor

@galfert galfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it, but the changes look ok to me.

@silverbucket silverbucket removed this from the Feeds Platform milestone Aug 28, 2021
@silverbucket silverbucket added the package:platform-feeds Issues related to the Feeds platform label Aug 28, 2021
Base automatically changed from socketio-middleware-callbacks to master August 30, 2021 16:48
@silverbucket silverbucket merged commit 57c5247 into master Aug 30, 2021
@silverbucket silverbucket deleted the fix-feeds-return-results branch August 30, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kredits-1 Small contribution package:platform-feeds Issues related to the Feeds platform state:ready type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants