fix ClassInfo.simpleName() #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `simpleName()` method used to return a wrong result in case of top-level
classes with dollar `$` in their names. For example, for the following class
```java
public class Top$Level {
}
```
the `ClassInfo.simpleName()` method used to return `Level`. This commit fixes
that by only calling `name.local()` in case the `name` is componentized (which
it always is, so just to be sure) and is _not_ marked inner. If it is marked
inner, the `simpleName()` method calls `name.withoutPackagePrefix()`.
It would be possible to call `withoutPackagePrefix()` always, but that method
allocates in case of componentized names, which we want to avoid if possible.
I think that we can't use the |
|
Hmm, yeah, that's true. My bad. The comment is wrong. The code is right :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simpleName()method used to return a wrong result in case of top-level classes with dollar$in their names. For example, for the following classthe
ClassInfo.simpleName()method used to returnLevel. This commit fixes that by only callingname.local()in case thenameis componentized (which it always is, so just to be sure) and is not marked inner. If it is marked inner, thesimpleName()method callsname.withoutPackagePrefix().It would be possible to call
withoutPackagePrefix()always, but that method allocates in case of componentized names, which we want to avoid if possible.Fixes #526