intern EquivalenceKeys for primitive types and class types of java.*
#540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EquivalenceKeys for primitive types and class types of java.*EquivalenceKeys for primitive types and class types of java.*
Primitive types and `java.*` class types are very commonly used and there is a limited number of them. Therefore, we can intern them safely (growth of the interning cache is naturally bounded) and improve allocation rate significantly. Further, this commit removes all calls to `Objects.hash()`, because each call allocates an array. It is especially useless when called with just one element. Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
b200cac to
5e41373
Compare
gsmet
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitive types and
java.*class types are very commonly used and there is a limited number of them. Therefore, we can intern them safely (growth of the interning cache is naturally bounded) and improve allocation rate significantly.Further, this commit removes all calls to
Objects.hash(), because each call allocates an array. It is especially useless when called with just one element.Co-authored-by: Guillaume Smet guillaume.smet@gmail.com