Skip to content

Fix detection of Object type in AnnotationOverlayImpl#annotation #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Fix detection of Object type in AnnotationOverlayImpl#annotation #498

merged 1 commit into from
Feb 17, 2025

Conversation

manovotn
Copy link
Contributor

Fixes #497

@Ladicek I did not yet figure out how to write a test for this in just Jandex (I have original reproducer in Quarkus), hints are welcome :)

@Ladicek
Copy link
Contributor

Ladicek commented Feb 13, 2025

Thanks! Testing should be fairly simple, just create an index with Object (Index.of(Object.class)), an annotation overlay on top of it, and attempt to get annotations.

@Ladicek Ladicek added this to the 3.2.7 milestone Feb 13, 2025
@Ladicek
Copy link
Contributor

Ladicek commented Feb 13, 2025

Also, the same issue occurs in other methods. Could you please fix them too?

@manovotn
Copy link
Contributor Author

Sure, I'll get back to it tomorrow

@manovotn manovotn force-pushed the annotationOverlayHasAnnotationFix branch from 09e7d59 to 269bf81 Compare February 14, 2025 15:08
@manovotn
Copy link
Contributor Author

I've pushed a change to other methods having similar issue and created a test using custom IndexView.
@Ladicek please re-review when you get the chance :)

@Ladicek Ladicek force-pushed the annotationOverlayHasAnnotationFix branch from 269bf81 to 633dc69 Compare February 17, 2025 08:55
@Ladicek Ladicek force-pushed the annotationOverlayHasAnnotationFix branch from 633dc69 to 09ca244 Compare February 17, 2025 08:57
@Ladicek Ladicek merged commit 36fdcea into smallrye:main Feb 17, 2025
35 checks passed
@Ladicek
Copy link
Contributor

Ladicek commented Feb 17, 2025

Thanks!

@manovotn manovotn deleted the annotationOverlayHasAnnotationFix branch February 17, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.

AnnotationOverlayImpl#annotation does not detect Object properly when searching for inherited annotations
2 participants
@manovotn @Ladicek