Skip to content

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Jun 14, 2023

  • code scan cron
  • dependabot automerge
  • triage

- code scan cron
- dependabot automerge
- triage
@dopey dopey requested a review from maraino June 14, 2023 02:42
@dopey dopey enabled auto-merge June 14, 2023 02:42
@hslatman hslatman disabled auto-merge June 14, 2023 05:12
@hslatman
Copy link
Member

hslatman commented Jun 14, 2023

#8 should go first, I think. Should have some of the same changes. Just marked it ready for review.

Kept the old CI as a separate file for legacy support. We would release that as the v1. Then discontinue (largely) it in v2.

We may want to keep testing/building with more Go versions than we generally do for this repo.

maraino
maraino previously approved these changes Jun 14, 2023
@hslatman hslatman enabled auto-merge June 14, 2023 21:32
@hslatman hslatman requested a review from maraino June 14, 2023 21:32
@maraino maraino disabled auto-merge June 14, 2023 21:34
maraino
maraino previously approved these changes Jun 14, 2023
Copy link

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I disabled auto-merge per #9 (comment)

@dopey dopey enabled auto-merge (squash) June 14, 2023 21:40
@dopey dopey merged commit 7c280be into main Jun 14, 2023
Copy link

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dopey dopey deleted the max/only-latest-golang branch June 14, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants