Skip to content

EncryptedContent needs to be implicitly tagged and not explicit #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

EncryptedContent needs to be implicitly tagged and not explicit #9

wants to merge 1 commit into from

Conversation

grk-it
Copy link

@grk-it grk-it commented Sep 13, 2023

Name of feature:

bug: EncryptedContent needs to be implicit but tagged explicit

Pain or issue this feature alleviates:

Against stricter parsers the emitted EncryptedContent fails to get parsed since it's considered explicit and not implicit

In what environments or workflows is this feature supported?

I am currently using: go version go1.20.7 darwin/amd64

Supporting links/other PRs/issues:

Issue filed: mozilla-services#84
PR opened here as well: mozilla-services#83

Related fix: fullsailor@cddbb99 But this is not sufficient to make the emitted EncryptedContent implicit.

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grk-it grk-it changed the base branch from patches to master September 13, 2023 18:19
@grk-it grk-it force-pushed the dev/grk/rfc_deviation__EncryptedContent branch 2 times, most recently from 0fdfb60 to 5f6dbff Compare September 13, 2023 18:55
@grk-it grk-it mentioned this pull request Sep 13, 2023
Closed
@grk-it
Copy link
Author

grk-it commented Sep 13, 2023 

➜  pkcs7 git:(dev/grk/rfc_deviation__EncryptedContent) ✗ GODEBUG=x509sha1=1 make test
go test -covermode=count -coverprofile=coverage.out .
ok  	go.mozilla.org/pkcs7	25.296s	coverage: 69.2% of statements

@grk-it
Copy link
Author

grk-it commented Sep 14, 2023

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Just fyi, I have completed this requirement.

@grk-it grk-it force-pushed the dev/grk/rfc_deviation__EncryptedContent branch from 5f6dbff to 8f53792 Compare September 14, 2023 17:13
@hslatman
Copy link
Member

Thank you, @grk-it. Am going to take a look soon!

@grk-it grk-it mentioned this pull request Sep 27, 2023
Open
@hslatman hslatman mentioned this pull request Oct 27, 2023
Merged
@hslatman
Copy link
Member

Closing this in favor of #19. @grk-it could you (re)approve the CLA?

@hslatman hslatman closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grk-it @CLAassistant @hslatman @grkarthik