Rebased patches branch #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs/decrypters Make smallstep's pkcs7 fork support RSA key handles returned from any private key type that returns an RSA public key. Specifically, this addresses the need to use key handles returned by piv-go that are of the `piv.keyRSA` type. Signed-Off-By: Dan Fuhry <dan@fuhry.com>
Changes from mozilla-services#48 are included in this commit. Slightly adapted to fit with how we work with `crypto.Decrypter`.
Currently the test suite still goes back as far as Go 1.12. This failed the test.
Addressing most of the review comments.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased the patches branch to satisfy CLA.
Created a new PR instead of force pushing for clarity.
This replaces #1