Skip to content

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented Jun 14, 2023

This has to be merged into #1 first. Then we merge that into master, and make that the default branch again.

@hslatman hslatman requested a review from maraino June 14, 2023 20:52
@hslatman hslatman mentioned this pull request Jun 14, 2023
@hslatman hslatman enabled auto-merge June 14, 2023 20:58
@hslatman
Copy link
Member Author

I've made them all RSA PRIVATE KEY now and fixed the comment.

@hslatman hslatman requested a review from maraino June 14, 2023 21:52
Copy link

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add support for PKCS#8 in a different PR using x509.ParsePKCS8PrivateKey().

@hslatman hslatman merged commit 70725a6 into patches Jun 15, 2023
@hslatman hslatman deleted the herman/fix-errors branch June 15, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants