Skip to content

Patches #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 27 commits into from
Closed

Patches #1

wants to merge 27 commits into from

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented May 11, 2022 •
edited
Loading

The branch of this PR contains a selection of (existing) patches and additional functionality.

@hslatman hslatman mentioned this pull request Oct 21, 2022
Merged
fuhry and others added 2 commits October 22, 2022 09:45
@fuhry
decrypt: support for RSA keys from piv-go and other generic RSA signe…
e6d0478 
…rs/decrypters

Make smallstep's pkcs7 fork support RSA key handles returned from any private key type that returns an RSA public key.

Specifically, this addresses the need to use key handles returned by piv-go that are of the `piv.keyRSA` type.

Signed-Off-By: Dan Fuhry <dan@fuhry.com>
@maraino
Merge pull request #3 from fuhry/piv-rsakey-support
e1aab68 
decrypt: support for RSA keys from piv-go and other generic RSA signers/decrypters
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ fuhry
✅ hslatman
✅ dopey
✅ maraino
❌ Nisarga Patel

Nisarga Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hslatman hslatman changed the title Patches (WIP) Patches Oct 25, 2022
@hslatman
Copy link
Member Author

@maraino I've made this the default base branch for now.

hslatman and others added 11 commits March 2, 2023 13:09
@hslatman
Add support for RSA-OAEP decryption
da52a18 
Changes from mozilla-services#48 are
included in this commit. Slightly adapted to fit with how we
work with `crypto.Decrypter`.
@hslatman
Add support for more RSA-OAEP algorithms in Decrypt
19faf5b
@hslatman
Remove the %w formatting directive
fac3794 
Currently the test suite still goes back as far as Go 1.12. This
failed the test.
@hslatman
Refactor decryption tests into more common table structure
1ff238d
@hslatman
Fix review remarks
b1fb0e5
@hslatman
Add SHA224 and improve errors returned
76fd9de 
Addressing most of the review comments.
@hslatman
Merge pull request #4 from smallstep/herman/rsa-oaep
4c09408 
Add support for RSA-OAEP decryption
@hslatman
Add support for RSA-OAEP (key) encryption
2a08e5a
@hslatman
Remove %w modifier
c68139e
@hslatman
Remove wrong decryption algorithms
6d860e2
@hslatman
Add references to IETF RFCs to signature and encryption algorithms
6323264
@hslatman hslatman mentioned this pull request May 19, 2023
Closed
@hslatman hslatman marked this pull request as ready for review June 14, 2023 09:07
@hslatman hslatman requested review from dopey and maraino June 14, 2023 09:20
@hslatman
Copy link
Member Author

hslatman commented Jun 14, 2023 •
edited
Loading

Will rename the module to github.com/smallstep/pkcs7 in a follow-up PR, also updating the README.md in the process.

@dopey regarding CI: I'll set this up with our shared workflows in that PR too. I think I'll do it in a similar way as with smallstep/scep#8, so that we have our shared workflows, as well as the old workflow that tests some older Go versions for legacy compatibility. We can drop support for those after a while, imo.

maraino
maraino requested changes Jun 14, 2023
View reviewed changes
@hslatman hslatman mentioned this pull request Jun 14, 2023
Merged
maraino
maraino approved these changes Jun 15, 2023
View reviewed changes
Copy link

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's add pkcs#8 in a different PR using x509.ParsePKCS1PrivateKey()

@hslatman hslatman mentioned this pull request Jun 15, 2023
Merged
@hslatman
Copy link
Member Author

Closing in favor of #8

@hslatman hslatman closed this Jun 15, 2023
@hslatman hslatman deleted the patches branch October 22, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

@dopey dopey Awaiting requested review from dopey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hslatman @CLAassistant @maraino @fuhry @dopey