Skip to content

Add support for tokens with no pins #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Add support for tokens with no pins #730

merged 2 commits into from
Mar 25, 2025

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Mar 20, 2025

Description

This commit sets the option LoginNotSupported if no pin is set. Servers using the p11-kit server protocol might not have a pin.

@hslatman should we do that? Or add an extra option?
We don't have any other way to set a pin, so doing this I think is ok for now.

@maraino
Add support for tokens with no pins
bb1646d 
This commit sets the option LoginNotSupported if no pin is set.
Servers using the p11-kit server protocol might not have a pin.
@maraino maraino requested a review from hslatman March 20, 2025 20:23
@hslatman
Copy link
Member

An additional option specifically for this behavior might be better, as the LoginNotSupported config controls the login flow in crypto11. I think performing a login with an empty PIN could still be useful, although I don't know if empty PINs are something that are supported generally.

@maraino
Copy link
Contributor Author

maraino commented Mar 24, 2025

An additional option specifically for this behavior might be better, as the LoginNotSupported config controls the login flow in crypto11. I think performing a login with an empty PIN could still be useful, although I don't know if empty PINs are something that are supported generally.

What do you think about ed0b190? It supports empty pins with pin-value=.

Using no special arguments matches better with tooks like pkcs11-tool where it doesn't attempt a login if you don't add a pin.

@hslatman
Copy link
Member

Yeah, this seems more explicit.

@maraino maraino merged commit 5edb050 into master Mar 25, 2025
12 checks passed
@maraino maraino deleted the mariano/no-pin branch March 25, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hslatman hslatman hslatman approved these changes

Assignees
No one assigned
Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maraino @hslatman