Allow locating certificates using issuer + subject CN in CAPI KMS. #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraino
requested changes
Apr 30, 2025
Co-authored-by: Mariano Cano <mariano.cano@gmail.com>
Co-authored-by: Mariano Cano <mariano.cano@gmail.com>
Co-authored-by: Mariano Cano <mariano.cano@gmail.com>
Co-authored-by: Mariano Cano <mariano.cano@gmail.com>
joshdrake
commented
May 1, 2025
| return uintptr(kh), nil | ||
| } | ||
|
|
||
| func cryptFindCertificateKeyContainerName(certContext *windows.CertContext) (string, error) { |
There was a problem hiding this comment.
@maraino This function is not currently used, and I think it will ultimately need to change a bit, but I'm leaving it in. Right now, it will populate the certificate context when the DLL calls succeed, and the error handling is now correct based on feedback.
maraino
approved these changes
May 1, 2025
Comment on lines
+968
to
+970
| if rsaOpts.SaltLength == rsa.PSSSaltLengthEqualsHash { | ||
| rsaOpts.SaltLength = rsaOpts.Hash.Size() | ||
| } |
There was a problem hiding this comment.
Not cryptical, I can do this later, but when SaltLength is rsa.PSSSaltLengthAuto the salt length is:
(modulus_key_size - 1 + 7)/8 - hash_length - 2
For example, for a 4096-bit modules key and SHA256 it should be:
(4096 - 1 + 7)/8 - 32 - 2 = 478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support a
cnargument in CAPIKMS URIs. It must be provided in conjunction with the issuer name. Since these parameters may not be enough to uniquely identity certificates, the first certificate matching the criteria is returned.💔Thank you!