Add MinLen validator #164
Merged
Add MinLen validator #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraino
requested changes
Feb 26, 2025
ui/options.go
Outdated
Comment on lines
148
to
150
| func WithValidateMinLen(length int) Option { | ||
| return WithValidateFunc(MinLen(length)) | ||
| } |
There was a problem hiding this comment.
I would use WithValidateMinLength and MinLength instead of MinLen. If we want to shorten it, we can name it WithMinLength.
ui/validators.go
Outdated
|
|
||
| // MinLen is a validation function that checks for a minimum length. | ||
| // An input length <= 0 indicates that the check should not be performed. | ||
| func MinLen(length int) promptui.ValidateFunc { |
ui/validators.go
Outdated
Comment on lines
85
to
86
| re := regexp.MustCompile(`\s+`) | ||
| next := re.ReplaceAllString(s, "") |
There was a problem hiding this comment.
Please no, you can use strings.TrimSpace(s).
There was a problem hiding this comment.
or perhaps just strings.TrimRightFunc(s, unicode.IsSpace) as we use in other places.
- MinLen -> MinLength - regex -> strings.TrimSpace
maraino
reviewed
Feb 27, 2025
maraino
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.