Skip to content

Improves readability of default password #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

sswastik02
Copy link
Contributor

Name of feature:

Improves readability of default password

Pain or issue this feature alleviates:

Uses only alphanumeric passwords so that other softwares works on these passwords

In what environments or workflows is this feature supported?:

All environments

Supporting links/other PRs/issues:

fixes smallstep/cli#283

💔Thank you!

Replaces the use of `randutil.ASCII` -> `randutil.Alphanumeric` to make
the default password more readable

Signed-off-by: sswastik02 <40518186+sswastik02@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Jun 1, 2024

CLA assistant check
All committers have signed the CLA.

@sswastik02
Copy link
Contributor Author

Requesting to approve workflows for this PR, so that I can know if any changes are necessary for the workflows to pass

@hslatman hslatman requested a review from dopey June 4, 2024 17:28
@sswastik02
Copy link
Contributor Author

Hi @dopey,
Please do let me know if any changes are necessary

@dopey dopey merged commit 29dce23 into smallstep:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated passwords are lovecraftian nightmares.
3 participants