Handle LoadVintage error when contexts are not in use
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, some code was customized in blackfriday. @maraino will know better. |
dopey
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses smallstep/certificates#1745. If the contents of
defaults.jsonwere somehow mangled and failed to be parsed as JSON, the error was ignored. Now it's returned up.Not much we can do for the Go vulnerability at this time.
Would be nice if the
blackfridaypackage could just be linted, but there were quite some issues with it, and it appeared to be copied from https://github.com/russross/blackfriday. Was some code customized in the copy to make it work in our programs?