Skip to content

SlevomatCodingStandard.Commenting.AnnotationName: New sniff to check incorrect annotation names #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

SlevomatCodingStandard.Commenting.AnnotationName: New sniff to check incorrect annotation names #1557

merged 1 commit into from
Apr 21, 2023

Conversation

kukulich
Copy link
Contributor

Fixes #1556

@kukulich kukulich mentioned this pull request Apr 21, 2023
Closed
@greg0ire
Copy link

This seems to be working for @inheritdoc, but not for {@inheritdoc}.

@kukulich
Copy link
Contributor Author

@greg0ire Please try new version.

@phansys
Copy link

phansys commented Apr 21, 2023

I've tested 35682c9 and, IMO, it works as expected. 🎉

@greg0ire
Copy link

Let's trust @phansys on this 👍

@phansys
Copy link

phansys commented Apr 21, 2023 •
edited
Loading

Don't trust me. Trust the pipeline :trollface:
Wrong casing was used at @inheritdoc and {@inheritdoc} to test the behavior: https://github.com/doctrine/dbal/pull/6015/files#diff-d17f2d94f51af520ce5af31f18599ae31ed2b5cf3a667f3d99bbc3408eac977aL64.

@kukulich kukulich merged commit 43d5d8c into master Apr 21, 2023
@kukulich kukulich deleted the annotations branch April 21, 2023 14:39
@phansys phansys mentioned this pull request Apr 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for valid PHPDoc tags in a case sensitive way
3 participants
@kukulich @greg0ire @phansys