Skip to content

ci(security): require access checks to pass before running unit tests #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

ci(security): require access checks to pass before running unit tests #279

merged 2 commits into from
Jan 16, 2024

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Jan 16, 2024

Summary

This PR requires the access_check step to pass before running unit_tests to prevent unexpected changes from branched PRs happening in actions.

A note about the access_check is also added to the workflow file.

Requirements

@zimeg zimeg added security semver:patch github_actions Pull requests that update GitHub Actions code labels Jan 16, 2024
@zimeg zimeg added this to the 1.25 milestone Jan 16, 2024
@zimeg zimeg requested a review from filmaj January 16, 2024 21:09
@zimeg zimeg self-assigned this Jan 16, 2024
filmaj
filmaj approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it so 👉

@zimeg zimeg merged commit 84a8f7d into slackapi:main Jan 16, 2024
@zimeg zimeg deleted the unit-access branch January 16, 2024 21:11
@zimeg
Copy link
Member Author

zimeg commented Jan 16, 2024

@filmaj appreciate the speedy review very much 🙇 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@filmaj filmaj filmaj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@zimeg zimeg

Labels
github_actions Pull requests that update GitHub Actions code security semver:patch
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
2 participants
@zimeg @filmaj