Skip to content

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Jun 18, 2025

Summary

This PR removes links to webpages that are no longer referenced in markdown within the README.md file and also inlines these links on "infinite" lines to avoid similar patterns in future changes. 👾

Preview

This should match the current README.md:

https://github.com/zimeg/slack-github-action/tree/docs-remove-urls?tab=readme-ov-file#slack-send-github-action

Requirements

@zimeg zimeg added this to the 2.2 milestone Jun 18, 2025
@zimeg zimeg self-assigned this Jun 18, 2025
@zimeg zimeg added the docs Improvements or additions to documentation label Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (82b86fb) to head (fa50cdb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           7        7           
  Lines         722      722           
=======================================
  Hits          721      721           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg
Copy link
Member Author

zimeg commented Jun 18, 2025

@lukegalbraithrussell Thanks for the kind review 🙏 ✨

I'm in the process of rotating tokens with required approvals, but once this matches what we're hoping for with tests passing I will merge this PR.

@zimeg zimeg merged commit b6c49e4 into slackapi:main Jun 18, 2025
5 of 8 checks passed
@zimeg zimeg deleted the docs-remove-urls branch June 18, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants