Skip to content

Clean up duplicated configurations #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2024
Merged

Clean up duplicated configurations #159

merged 2 commits into from
Mar 3, 2024

Conversation

ganadist
Copy link
Contributor

@ganadist ganadist commented Mar 3, 2024

Guidelines

  • Include change from Update agp to v8.3.0 - autoclosed #154
  • Clean up duplicated AGP configurations
    • using androidx vectordrawable
    • bytecode version setting
    • lint configuration
  • move version information to version catalogs
    • jvm bytecode version
    • targetSdk

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

@ganadist ganadist requested a review from skydoves as a code owner March 3, 2024 03:59
skydoves
skydoves approved these changes Mar 3, 2024
View reviewed changes
Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, @ganadist! Thank you for your continuous great contribution 🙌

@skydoves skydoves merged commit 8f146b3 into skydoves:main Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganadist @skydoves