Skip to content

Conversation

lorenzovngl
Copy link
Contributor

@lorenzovngl lorenzovngl commented Dec 11, 2022

Guidelines

Hi, I noticed that in the activity of pokémon details, where we can se the base statistics, the Italian translation of prefixes for each statistic is not accurate. My fixes are:

  • PS as Punti salute
  • ATT as Attacco
  • DIF as Difesa
  • VEL as Velocità
  • ESP as Esperienza

These labels are the same used in the official Pokédex (Italian version).

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Preparing a pull request for review

Ensure your change is properly formatted by running:

$ ./gradlew spotlessApply

Please correct any failures before requesting a review.

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skydoves skydoves merged commit 86c70e9 into skydoves:main Dec 11, 2022
@lorenzovngl
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants