This repository was archived by the owner on Sep 10, 2025. It is now read-only.
improve db query performance, using between instead of strftime #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good, thank-you for your contribution :) |
|
@yorks: could you tell me which screen(s) is this query used on? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the different performance like this:
sqlite>
SELECT distinct state, COUNT(state) AS CountOf FROM reports WHERE strftime('%d/%m/%Y', DATE(executed_at, 'unixepoch', 'localtime'))='15/04/2021' GROUP by state;state|CountOf
changed|154
failed|6532
CPU Time: user 2.118060 sys 0.109253
sqlite>
SELECT distinct state, COUNT(state) AS CountOf FROM reports WHERE executed_at between 1618416000 and 1618502399 GROUP by state;state|CountOf
changed|154
failed|6532
CPU Time: user 0.316440 sys 0.113149