This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add support for environments. #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! If I understand correctly this will close #54? I'm now no longer running puppet, or puppet-summary, as I consolidated a lot of my services but I'm happy to read your code and setup a quick test-environment to sanity-check it. Unfortunately that'll take me a couple of days, but I'll make sure I give feedback by Monday at the latest. Thanks again :) |
|
It took me longer than I wanted to get round to testing this; but it works well. Great job, thank-you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as in our setup we have a few environments, of which some tend to become old/orphaned easily and yet contain a lot of hosts, I've taken a stab at adding support for environments.
Database gets created with environment column and will automatically add it if it does not have it already. If running the server it will also attempt to re-parse all of the past reports and fill out null environment columns. This might take a while (if many reports) so could be a bit of a problem - might be better to make this optional or default to setting environment to production for empty ones.
I've added environment column to all of the web pages and Environments button on top left of the home page. The button allows browsing to either all or individual /environment/NAME pages which then show data only for those environments.
Finally, I can't claim to know go (really, my first time actually changing code) so I hope it's not too bad.
Thanks for a really useful utility!