Cache LSP completions. #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will close #111 by calculating possible completions only once, and then reusing them for the duration of our LSP server. This works because we only complete things within the standard-library which won't change mid-execution. If we ever supported completion of the users' code then this approach would need to be revisited, but we don't do that and don't want to at the moment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #111 by calculating possible completions only once, and then reusing them for the duration of our LSP server.
This works because we only complete things within the standard-library which won't change mid-execution.
If we ever supported completion of the users' code then this approach would need to be revisited, but we don't do that and don't want to at the moment.