MariaDB 11.5 support

evanelias · evanelias · commit 6165c9022011 · 2024-08-20T16:43:18.000-04:00
This commit marks MariaDB 11.5 as a supported DB flavor, now that its GA release occurred on 14 Aug 2024. This is a rolling (short term support) MariaDB server release. Note the following schema management impacts of MariaDB 11.5: * MariaDB 11.5 changes the default collation for Unicode character sets to use uca1400_ai_ci collations. See MDEV-25829. This only required a minor tweak to one of Skeema's test suite helper functions. Aside from this, uca1400 collation support was already added in ee25133 (Skeema v1.11.1). * Prior to MariaDB 11.5, the TIMESTAMP column type suffered from the Y2K38 limitation. This has now been solved; see MDEV-32188. Skeema's lint-has-time annotation message has been adjusted accordingly for MariaDB, depending on the server version. * Users of foreign keys should note that MariaDB 11.5.2 suffers from bug MDEV-34756, which means that when you ALTER a table to add a new foreign key, the existing data in the table is not validated against the new constraint by default, even with foreign_key_checks=ON. For a workaround, set global variable innodb_alter_copy_bulk to OFF for now. We expect the next quarter's MariaDB server releases to fix this bug. However, since 11.5 is a rolling release, there won't be a MariaDB 11.5.3 release, as rolling releases don't have updates after GA (X.Y.2).
diff --git a/internal/linter/check_has_time.go b/internal/linter/check_has_time.go
@@ -24,10 +24,15 @@ func hasTimeChecker(table *tengo.Table, createStatement string, _ *tengo.Schema,
 	for _, col := range table.Columns {
 		var message string
 		if strings.HasPrefix(col.TypeInDB, "timestamp") {
-			message = fmt.Sprintf(
-				"Column %s of %s is using type timestamp. This column type cannot store values beyond January 2038, which is problematic for software with long-term support requirements. It should not be used for storing arbitrary future dates, especially from user input.\nAlso note that timestamps have automatic timezone conversion behavior, between the time_zone session variable and UTC.",
-				col.Name, table.ObjectKey(),
-			)
+			prefix := fmt.Sprintf("Column %s of %s is using type timestamp. ", col.Name, table.ObjectKey())
+			suffix := "timestamps have automatic timezone conversion behavior, between the time_zone session variable and UTC."
+			if opts.flavor.IsMySQL() {
+				message = prefix + "This column type cannot store values beyond January 2038, which is problematic for software with long-term support requirements. It should not be used for storing arbitrary future dates, especially from user input.\nAlso note that " + suffix
+			} else if opts.flavor.MinMariaDB(11, 5) { // MariaDB 11.5+ fixes the Y2K38 problem with timestamp (assuming 64bit platforms)
+				message = prefix + "Note that " + suffix
+			} else { /* opts.flavor.IsMariaDB() && !opts.flavor.MinMariaDB(11, 5) */
+				message = prefix + "Prior to MariaDB 11.5, this column type cannot store values beyond January 2038. It should not be used for storing arbitrary future dates, especially from user input.\nAlso note that " + suffix
+			}
 			if oldTimestampDefaults && !alreadySeenTimestamp && !col.Nullable {
 				when := "MySQL 8"
 				if opts.flavor.IsMariaDB() {
diff --git a/internal/tengo/flavor.go b/internal/tengo/flavor.go
@@ -17,7 +17,7 @@ type Version [3]uint16
 // numbers; corresponding logic handles this appropriately.
 var (
 	LatestMySQLVersion   = Version{9, 0}
-	LatestMariaDBVersion = Version{11, 4}
+	LatestMariaDBVersion = Version{11, 5}
 )
 
 // Variables representing the oldest major.minor releases of MySQL and MariaDB
diff --git a/internal/tengo/tengo_test.go b/internal/tengo/tengo_test.go
@@ -229,10 +229,14 @@ func aTableForFlavor(flavor Flavor, nextAutoInc uint64) Table {
 	if flavor.MinMySQL(8, 0, 29) || flavor.MinMariaDB(10, 6) {
 		// MySQL 8.0.29+ and MariaDB 10.6+ report the legacy utf8 charset as utf8mb3.
 		// MySQL 8.0.30+ and MariaDB 10.6+ also update collation names accordingly.
+		// MariaDB 11.5+ changes utf8mb3's default collation to utf8mb3_uca1400_ai_ci.
 		utf8mb3 = "utf8mb3"
 		if !flavor.IsMySQL(8, 0, 29) {
 			utf8mb3DefaultCollation = "utf8mb3_general_ci"
 		}
+		if flavor.MinMariaDB(11, 5) {
+			utf8mb3DefaultCollation = "utf8mb3_uca1400_ai_ci"
+		}
 	}
 	lastUpdateCol := &Column{
 		Name:     "last_update",

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ type Version [3]uint16`
`17`	`17`	`// numbers; corresponding logic handles this appropriately.`
`18`	`18`	`var (`
`19`	`19`	`LatestMySQLVersion = Version{9, 0}`
`20`		`- LatestMariaDBVersion = Version{11, 4}`
	`20`	`+ LatestMariaDBVersion = Version{11, 5}`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`// Variables representing the oldest major.minor releases of MySQL and MariaDB`