docker: allow tmpfs on Mac/Windows; use smaller redo logs

evanelias · evanelias · commit d34824919e81 · 2024-11-01T19:28:47.000-04:00
This commit makes two performance improvements affecting workspace=docker, as well as Skeema's integration test suites: * Previously, when using docker-cleanup=destroy, the container would use a tmpfs mount automatically only on a native Linux host. This was due to a common misinterpretation of the Docker docs; tmpfs actually is also usable on Docker Desktop for MacOS or Windows. This is now fixed, and likewise for a few integration tests which can now leverage tmpfs on any host OS. * InnoDB redo logs for new containers are now set to their minimum allowed value of 4mb. Ordinarily, this could be problematic on MySQL 8+ even for a DDL-only workload on throwaway ephemeral container, because DDL in MySQL 8+ writes to the InnoDB-based data dictionary. However, this is now doable because the previous commit ca85df7 disables redo logging in MySQL 8+ for Skeema's workspace containers and integration test containers. Meanwhile, MySQL 5.x and MariaDB (any version) use frm files, so Skeema's DDL workload won't be constrained by a tiny redo log. The second change is primarily included here because it reduces memory usage when operating on tmpfs from the first change.
diff --git a/internal/applier/applier_test.go b/internal/applier/applier_test.go
@@ -185,7 +185,6 @@ func (s *ApplierIntegrationSuite) Setup(backend string) error {
 				Image:        backend,
 				RootPassword: "fakepw",
 				DataTmpfs:    (n > 0), // we destroy the 2nd container after this test in Teardown anyway
-
 			})
 			return err
 		})
diff --git a/internal/tengo/docker.go b/internal/tengo/docker.go
@@ -8,7 +8,6 @@ import (
 	"log"
 	"os"
 	"os/exec"
-	"runtime"
 	"strconv"
 	"strings"
 	"time"
@@ -82,7 +81,7 @@ type DockerizedInstanceOptions struct {
 
 	// Options that only affect new container creation:
 	DataBindMount       string // Host path to bind-mount as /var/lib/mysql in container
-	DataTmpfs           bool   // Use tmpfs for /var/lib/mysql. Only used if no DataBindMount, runtime.GOOS is Linux, and image is from a top-level repo (e.g. "foo" but not "foo/bar")
+	DataTmpfs           bool   // Use tmpfs for /var/lib/mysql. Only used if no DataBindMount, and image is from a top-level repo (e.g. "foo" but not "foo/bar")
 	EnableBinlog        bool   // Enable or disable binary log in database server
 	LowerCaseTableNames uint8  // lower_case_table_names setting (0, 1, or 2) in database server
 }
@@ -123,9 +122,8 @@ func CreateDockerizedInstance(opts DockerizedInstanceOptions) (*DockerizedInstan
 	}
 	if opts.DataBindMount != "" {
 		dflags = append(dflags, "-v {DATABINDMOUNT}")
-	} else if opts.DataTmpfs && runtime.GOOS == "linux" && !strings.ContainsRune(opts.Image, '/') {
-		// tmpfs can only be used on *native* Linux (not Docker Desktop for Mac/Win).
-		// It can also cause permission issues with some non-Docker-official images,
+	} else if opts.DataTmpfs && !strings.ContainsRune(opts.Image, '/') {
+		// tmpfs can cause permission issues with some non-Docker-official images,
 		// such as percona/percona-server; for this reason we only enable it for
 		// images from the top-level namespace, since these are known to support it.
 		dflags = append(dflags, "--tmpfs /var/lib/mysql")
@@ -136,7 +134,7 @@ func CreateDockerizedInstance(opts DockerizedInstanceOptions) (*DockerizedInstan
 	// instances used only for schema management, we can configure the server in a
 	// way that reduces resource usage and improves performance for this workload
 	serverArgs := []string{
-		"--innodb-log-file-size=16777216",       // use smaller 16MB redo log files, instead of default of 48MB-96MB (varies by flavor)
+		"--innodb-log-file-size=4194304",        // use smaller 4MB redo log files, instead of default of 48MB-96MB (varies by flavor)
 		"--innodb-buffer-pool-size=33554432",    // use smaller 32MB buffer pool, instead of default of 128MB
 		"--performance-schema=0",                // disable performance_schema to reduce memory usage and other overhead
 		"--skip-innodb-adaptive-hash-index",     // AHI not beneficial to DDL-based workload
