Skip to content

oneshot command finishes with 0 status when it occurs error. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2018
Merged

oneshot command finishes with 0 status when it occurs error. #11

merged 2 commits into from
Jan 26, 2018

Conversation

bukuro-m
Copy link
Contributor

@bukuro-m bukuro-m commented Jan 26, 2018 •
edited
Loading

issue: #10

Oneshot command finished with 1 status when error.

I also change error status from -1 to 1 in reference to http://tldp.org/LDP/abs/html/exitcodes.html.

@bukuro-m bukuro-m changed the title oneshot コマンドがエラーになったときにも正常終了してしまう oneshot command finishes with 0 status when it occurs error. Jan 26, 2018
@skahack skahack self-requested a review January 26, 2018 11:27
@skahack
Copy link
Owner

skahack commented Jan 26, 2018

Good catch 👍 Thank you

@skahack skahack merged commit b222f5a into skahack:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skahack skahack skahack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bukuro-m @skahack