Skip to content
This repository was archived by the owner on May 30, 2025. It is now read-only.

Conversation

thiagojedi
Copy link

Partially fixes #161

Mastodon 4.0 adds a new filter mechanism (stated by mastodon#94 (comment) ). This changing should make the "hide" action to work properly with this new field.

Should help with the "warn" action, but it involves UI changes that I'm not (yet) sure I know how to do.

@sk22
Copy link
Owner

sk22 commented Dec 25, 2022

ahhh omg thank you, will merge asap!
so "hide with a warning" posts aren't hidden at all by this implementation (yet), right? (except, i guess, the old filter implementation matches?)

@sk22
Copy link
Owner

sk22 commented Dec 25, 2022

(note to self, mainly) i'd also consider only using the old filter implementation if on a pre-4 mastodon instance

@thiagojedi
Copy link
Author

ahhh omg thank you, will merge asap!
so "hide with a warning" posts aren't hidden at all by this implementation (yet), right? (except, i guess, the old filter implementation matches?)

Hide with warning (filterAction == "warn") was introduced in 4.0 too, so I don't think it will do anything for now.

The old behavior is still there for cases where the new field isn't present (like 3.x servers).

@sk22 sk22 merged commit 6220ce6 into sk22:main Dec 28, 2022
@thiagojedi thiagojedi deleted the feat/4.0-filters branch January 9, 2023 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters being Ignored in Megalodon
2 participants