Skip to content

go.mod: bump up deps; CI: remove appveyor, add macOS #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

go.mod: bump up deps; CI: remove appveyor, add macOS #1460

merged 3 commits into from
Jun 20, 2025

Conversation

AkihiroSuda
Copy link
Contributor

@AkihiroSuda AkihiroSuda commented Jun 20, 2025 •
edited by thaJeztah
Loading

@AkihiroSuda AkihiroSuda mentioned this pull request Jun 20, 2025
Open
@AkihiroSuda
Copy link
Contributor Author

https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745

[Console](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745) [Messages ](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745/messages) [Tests ](https://ci.appveyor.com/project/sirupsen/logrus/builds/52271745/tests) Artifacts
Build started
git clone -q https://github.com/sirupsen/logrus.git c:\gopath\src\github.com\sirupsen\logrus
git fetch -q origin +refs/pull/1460/merge:
git checkout -qf FETCH_HEAD
Running Install scripts
set PATH=%GOPATH%\bin;c:\go\bin;%PATH%
go version
go version go1.13.3 windows/amd64
go get -t
go: downloading golang.org/x/sys v0.13.0
go: downloading github.com/stretchr/testify v1.10.0
go: extracting github.com/stretchr/testify v1.10.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: extracting gopkg.in/yaml.v3 v3.0.1
go: extracting github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting golang.org/x/sys v0.13.0
go: finding golang.org/x/sys v0.13.0
# golang.org/x/sys/windows
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\env_windows.go:47:12: undefined: unsafe.Add
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\exec_windows.go:163:20: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\security_windows.go:1342:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\security_windows.go:1349:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall.go:84:16: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:129:29: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:1030:20: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:1671:11: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:1695:11: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:1748:9: undefined: unsafe.Slice
c:\gopath\pkg\mod\golang.org\x\sys@v0.13.0\windows\syscall_windows.go:1748:9: too many errors
note: module requires Go 1.17

Appveyor seems to still use Go 1.13?
But I guess we can just remove Appveyor, as we now have Windows on GHA?

@AkihiroSuda AkihiroSuda changed the title go.mod: bump up deps go.mod: bump up deps; CI: remove appveyor Jun 20, 2025
@AkihiroSuda
CI: remove appveyor
3cc7e3c 
GHA should suffice for running tests on Windows

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
thaJeztah
thaJeztah reviewed Jun 20, 2025
View reviewed changes
@thaJeztah
Copy link
Collaborator

But I guess we can just remove Appveyor, as we now have Windows on GHA

Yes, makes sense to me. Less to maintain!

@thaJeztah
Copy link
Collaborator

I guess we could (should?) add macOS as well

@AkihiroSuda
go.mod: bump up deps
890868f 
The minimum Go version is now bumped up from 1.13 to 1.17.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
CI: add macOS
58ee73e 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title go.mod: bump up deps; CI: remove appveyor go.mod: bump up deps; CI: remove appveyor, add macOS Jun 20, 2025
thaJeztah
thaJeztah approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'm assuming AppVeyor will disappear after this, but we could probably do a test PR after this to see if it stops complaining (or if changes to the repo settings are needed)

@thaJeztah thaJeztah merged commit 70b8093 into sirupsen:master Jun 20, 2025
11 of 12 checks passed
@AkihiroSuda
Copy link
Contributor Author

Appveyor is failing for the master: https://ci.appveyor.com/project/sirupsen/logrus/builds/52271891

@thaJeztah Could you update the repo setting?

@thaJeztah
Copy link
Collaborator

😢 unfortunately I don't have access to settings; perhaps @sirupsen is able to (or to grant access). If possible, I also would not mind having @AkihiroSuda as co-maintainer.

Alternatively, we could add a stub AppVeyor config as a temporary workaround

This was referenced Aug 4, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update stretchr/testify to 1.9.0 to resolve 2 High sev Vulnerabilities found in go yaml lib from current version Bump version of stretchr/testify?
2 participants
@AkihiroSuda @thaJeztah