refactor: use cpp over c headers #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Sep 23, 2022
Additionally, add some missing headers. Related to bitcoin/bitcoin#26159.
|
@darosior At this point, how close is the code merged in Bitcoin Core (after the signing support PR) to what is in this repository? If the difference is substantial, perhaps it's better to make changes directly on the Bitcoin Core side, and then after signing support is done, resynchronize everything with this repo? |
|
Yes, i expect the diff is substantial. I was thinking of updating the code here once integration in Bitcoin Core is done.
I agree it's better to make the changes in Bitcoin Core first.
-------- Original Message --------
…On Sep 24, 2022, 2:40 PM, Pieter Wuille wrote:
***@***.***(https://github.com/darosior) At this point, how close is the code merged in Bitcoin Core (after the signing support PR) to what is in this repository?
If the difference is substantial, perhaps it's better to make changes directly on the Bitcoin Core side, and then after signing support is done, resynchronize everything with this repo?
—
Reply to this email directly, [view it on GitHub](#124 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FZZEEPDT6SJL3SRXCTV74HELANCNFSM6AAAAAAQUCOQAY).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@fanquake So I suggest just PR'ing this to Bitcoin Core directly at this point. We'll "backport" it here after the miniscript signing PR is merged there. |
|
Ok. I'll take this back to bitcoin/bitcoin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, add some missing headers.
Related to bitcoin/bitcoin#26159, see bitcoin/bitcoin#26159 (comment).