Only return peers that support bloom filters #34
Conversation
| if (clientVersion < NO_BLOOM_VERSION) { | ||
| if (!(services & NODE_NETWORK)) return false; | ||
| } else { | ||
| if (!(services & (NODE_NETWORK | NODE_BLOOM))) return false; |
There was a problem hiding this comment.
I think you want: (services & (NODE_NETWORK | NODE_BLOOM)) != (NODE_NETWORK | NODE_BLOOM).
There was a problem hiding this comment.
Or (more obscure):
(services | ~(NODE_NETWORK | NODE_BLOOM)) != -1
bitcoinj SPV clients do no peer discovery beyond the DNS seeds, so it's possible that the seeds will only give them non-bloom-supporting peers with BIP111, NODE_BLOOM.
8bc7f7d to
fcdf7df
Compare
|
I though bitcoinj has moved to the "Cartographer" stuff (http seed)? |
|
Nevermind my last comment. Didn't realized that we are talking on the bitcoin-seeder repository ... :) |
|
Incidentally, we may not want to actually merge this pull-req - better if bitcoinj implements proper peer discovery like breadwallet does. |
|
Isn't this covered today by |
|
@Sjors Yes I think it is; closing. |
bitcoinj SPV clients do no peer discovery beyond the DNS seeds, so it's possible that the seeds will only give them non-bloom-supporting peers with BIP111, NODE_BLOOM.