Skip to content

Conversation

lkmill
Copy link

@lkmill lkmill commented Jun 28, 2023

This PR is an attempt to fix #48.

I would like to add some tests, but this would require mocking a bunch of dependencies. Is this possible with ESM and Ava?

@sindresorhus
Copy link
Owner

You could use https://github.com/iambumblehead/esmock

@simonhyll
Copy link

What's the status on this? We're considering whether we should tell people in the Tauri docs to use version 7 or if this will be resolved soon anyway so we can recommend using version 8 🙂

@lkmill
Copy link
Author

lkmill commented Sep 28, 2023

@simonhyll sorry, i completely forgot i made a PR myself. i'll try get some tests up this weekend

@sindresorhus
Copy link
Owner

Bump :)

@nneewwoo
Copy link

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8.0.0 always returns *.*.*.0 instead of actual IP
4 participants