Skip to content

Improve "bultin" globals creation #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

Improve "bultin" globals creation #303

merged 5 commits into from
Jun 11, 2025
+217 −195

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jun 10, 2025 •
edited
Loading

After this change,

Once the year updated, eg tc39/ecma262@dd4300d

We'll create "es2026".

If there are new globals,

it will write

import {mergeGlobals} from '../utilities.mjs';
import es2025Globals from './es2025.mjs';

export default mergeGlobals(es2025Globals , {
  NEW_GLOBAL: false,
});

if no new globals added, it will just re-export the previous year version

export {default} from './es2025.mjs';

Log: https://github.com/sindresorhus/globals/actions/runs/15565280409/job/43827717908?pr=303#step:6:11

Fixes #302
Closes #294 (not accept, update from draft seems better)

@fisker fisker marked this pull request as ready for review June 10, 2025 16:57
@sindresorhus sindresorhus merged commit abd92bb into sindresorhus:main Jun 11, 2025
5 checks passed
@fisker fisker deleted the builtin branch June 11, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve "bultin" globals creation Get builtin globals from released spec instead of draft
2 participants
@fisker @sindresorhus