Skip to content

fix: remove unnecessary type assertions #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: remove unnecessary type assertions #2362

merged 1 commit into from
Jul 10, 2024

Conversation

bjornstar
Copy link
Contributor

The main branch is currently failing due to a tslint rule:

Error: /Users/runner/work/got/got/source/core/options.ts: line 953, col 17, Error - This assertion is unnecessary since it does not change the type of the expression. (@typescript-eslint/no-unnecessary-type-assertion)
Error: /Users/runner/work/got/got/source/core/utils/options-to-url.ts: line 66, col 15, Error - This assertion is unnecessary since it does not change the type of the expression. (@typescript-eslint/no-unnecessary-type-assertion)

So I removed the unnecessary type assertions.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.

@sindresorhus sindresorhus merged commit 561a376 into sindresorhus:main Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornstar @sindresorhus