Fix got.mergeOptions(...) types
#953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The fix is to replace Line 73 in d11dbe4 with mergeOptions(...sources: Options[]): NormalizedOptions;I forgot to update it in #921 I'm not sure how to test the types though. Should we use /cc @sindresorhus |
If we really need to test the actual types, we could use something like this: type AssertEqual<T, Expected> =
T extends Expected
? (Expected extends T ? true : never)
: never;But I don't think it's needed in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage for mergeOptions usage similar to that in the readme.
Not passing because I'm not sure what the fix should be, willing to make the change. Partial?