Major refactoring #921
Merged
Major refactoring #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Nov 5, 2019
szmarczak
commented
Nov 6, 2019
sindresorhus
reviewed
Nov 7, 2019
Url usageUrl usage, drop query option
c919fee to
b803076
Compare
Url usage, drop query option
This comment has been minimized.
This comment has been minimized.
|
Okay, the only thing to do is to review documentation. Make necessary changes, then it's good to merge. |
8 tasks
sindresorhus
requested changes
Nov 15, 2019
sindresorhus
requested changes
Nov 15, 2019
|
TODO: |
| Parsing method used to retrieve the body from the response. Can be `'default'`, `'text'`, `'json'` or `'buffer'`. The promise has `.json()` and `.buffer()` and `.text()` functions which set this option automatically. | ||
| Parsing method used to retrieve the body from the response. | ||
|
|
||
| - `'default'` - if `options.encoding` is `null`, the body will be a Buffer. Otherwise it will be a string unless it's overwritten in a `afterResponse` hook, |
There was a problem hiding this comment.
Should we remove the null thing to get buffer as the user can just do responseType: 'buffer' instead? Which is also much clearer.
There was a problem hiding this comment.
Sure, I'll send a PR.
|
Really nice work on this!! 🙌 I'm glad you got to this before the release. |
4 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urlusagequeryoptiongot.mergeInstancesbeforeRetryandbaseUrl#867 (if possible, replacesprefixUrlin the URL)http.request(url, options, callback)when targeting Node 10.9.0 #580204 No Contentwhen parsing response #925promise.json()doesn't work if the promise has been already resolved #931afterResponsehook should triggerbeforeRetryhook #918options.streamtooptions.isStreamgot.create(...)undefinedare removed (bf206ca was made because Make it possible to unset the defaultuser-agentheader #496 was followed by Support discrete client configuration viagot.create([options])#495 and Support discrete client configuration viagot.create([options])#495 had differentmergemechanism)Checklist