Skip to content

Add support Office PowerPoint 2007 (macro-enabled) slide show #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Apr 25, 2025

Normalized MIME-types to lowercase.
MIME-type are defined to be case insensitive.

Add support for:

  • .ppsx, application/vnd.openxmlformats-officedocument.presentationml.slideshow
  • .ppsx, application/vnd.ms-powerpoint.slideshow.macroEnabled.12

MIME type reference: Register the 2007 Office system file format MIME types on servers

Resolves #746

@Borewit Borewit self-assigned this Apr 25, 2025
@Borewit Borewit added the enhancement Add new functionality label Apr 25, 2025
@Borewit Borewit mentioned this pull request Apr 25, 2025
2 tasks
@PRR24
Copy link

PRR24 commented Apr 25, 2025

Not related to the task, but reviewing the changes I noticed that all macroEnabled.12 mime-s are in camelCase except
application/vnd.ms-excel.template.macroenabled.12

package.json also got unrelated "packageManager" entry. Not sure, if it is intentional or a mistake.

Other than that, looks exactly as expected, nice job.

@Borewit Borewit force-pushed the detect-ppsx-and-ppsm branch from edf2e17 to b2055f2 Compare April 25, 2025 15:07
Add support for:
- `.ppsx`, `application/vnd.openxmlformats-officedocument.presentationml.slideshow`
- `.ppsx`, `application/vnd.ms-powerpoint.slideshow.macroEnabled.12`

MIME type reference: [Register the 2007 Office system file format MIME types on servers](https://learn.microsoft.com/en-us/previous-versions/office/office-2007-resource-kit/ee309278%28v=office.12%29)

Resolves #746
@Borewit Borewit force-pushed the detect-ppsx-and-ppsm branch from b2055f2 to abf3ac3 Compare April 25, 2025 15:12
@Borewit
Copy link
Collaborator Author

Borewit commented Apr 25, 2025

Thx! @PRR24

  • Removed packageManager, was not intentional .
  • MIME are defined to be case insensitive. Adjusted other types be lower case, and the switch case insensitive.

@Borewit Borewit requested a review from sindresorhus April 25, 2025 15:18
@sindresorhus sindresorhus merged commit f1b4c7a into main Apr 26, 2025
6 checks passed
@sindresorhus sindresorhus deleted the detect-ppsx-and-ppsm branch April 26, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ppsx
3 participants