Skip to content

Add support for RealMedia #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2025
Merged

Add support for RealMedia #740

merged 1 commit into from
Feb 23, 2025

Conversation

matt-oakes
Copy link
Contributor

References:

I have only added support for the RealMedia format and not the older RealAudio. This is because ffmpeg only supports this format and I don't have good fixtures for the older format.

Borewit
Borewit requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per guidance:

Existing signatures requiring same sample length (same signature group) will be tested prior to your new detections. Yours will be last. (rational: common formats first).

Please make this detection the last detection in group of 4 byte signatures.

@matt-oakes
Copy link
Contributor Author

@Borewit Thanks for the review. Sorry, I missed that part of the requirements.

I have fixed that now and put it at the bottom of the 4-byte section. I have also added the missing heading comment for the 5-byte DRACO check to make it clearer that isn't a 4-byte one. I can remove that from this PR if you prefer.

@matt-oakes matt-oakes requested a review from Borewit February 21, 2025 11:14
Borewit
Borewit approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@Borewit Borewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

@sindresorhus sindresorhus merged commit d05d49d into sindresorhus:main Feb 23, 2025
3 checks passed
@matt-oakes matt-oakes deleted the realmedia branch February 24, 2025 07:19
@matt-oakes
Copy link
Contributor Author

Thank you for the review and merging this! Roughly how often do you produce a new release for this to be available publicly?

@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/file-type/releases/tag/v20.2.0

@matt-oakes
Copy link
Contributor Author

Thank you and thanks for your work on this library. It's very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borewit Borewit Borewit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-oakes @sindresorhus @Borewit