[WIP] make js / d.ts files consistent #735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considered to be abandoned. |
|
@Borewit Hi, I'm sorry for the lack of feedback, I was in a hurry for my company's project 😒 , and didn't had the time to review. I've just checked what you did, and it seems to me you finally choose the opposite solution you exposed here, but anyway the main thing is that all look consistent now. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a WIP related #715
As per #715 (comment) , I've removed all the FileTypeOptions arguments passed in helper functions
fileTypeFromXXX.Some tests are now failing, it emphasizes the fact that some functions currently have the ability to take a FileTypeOptions argument but not others.
I've also reorganized a bit the file structure of core.js/core.d.ts and index.js/index.d.ts to make them more or less aligned.
Please let me know if that makes sense, and what would you do about the "helpers" functions, make all of them or none of them able to take FileTypeOptions argument.