Improve WebP detection #733
Merged
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
approved these changes
Feb 5, 2025
Previously WebP parser checked for a plain string in middle of a file, enabling possible vulnerabilities like uploading of JSON files when only images are meant to be uploaded. Considering WebP files are stored within RIFF containers, it makes sense to check whether a WebP file is stored in such container.
d35ac84 to
bc63521
Compare
|
Rebased. |
Borewit
approved these changes
Feb 5, 2025
|
Thank you, @sugar700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously WebP parser checked for a plain string in middle of a file, enabling possible vulnerabilities like uploading of JSON files when only images are meant to be uploaded.
Considering WebP files are stored within RIFF containers, it makes sense to check whether a WebP file is stored in such container.
WebP specification saying that WebP files start with RIFF: https://developers.google.com/speed/webp/docs/riff_container?hl=pl#webp_file_header
Fixes #731