Ensure web-stream is released after detection #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing |
d66aac0 to
2238d63
Compare
Release of strtok3 v9.0.1, will cause problems with file-type v19.5.0 (reason CI was failing). It exposes a the following issue: Lines 13 to 17 in 0e91f7b where the tokenizer is closed after return the promise, and not after resolving the promise. Raised bug: #681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fileTypeFromBlob- a.readFromStream WebStreamReader.js - TypeError: network error #678fileTypeFromStreamthrows an error in combination with strtok3@9.0.1 #681