Add deepKeys()
#94
Merged
Add deepKeys()
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
|
The PR is complete, but an AVA bug is causing CI to fail |
|
// @mmkal |
Should mention all the use-cases. |
mmkal
reviewed
Feb 14, 2022
mmkal
reviewed
Feb 14, 2022
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
mmkal
reviewed
Feb 15, 2022
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
|
Can you fix the merge conflict? |
mmkal
reviewed
Feb 16, 2022
| }), [ | ||
| 'a\\.b.c.d', | ||
| 'a\\.b.c.d[0]', |
There was a problem hiding this comment.
If you want to be extra thorough you could cover the case where an array contains a complex object too, but I imagine it’s fine.
|
Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93