Support 60 FPS #173
Merged
Support 60 FPS #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual result will be 50 FPS, but I doubt the user will notice. See: #161
|
gifski doesn't take fps, but delay that is multiple of 10ms (per GIF spec), and it will store the value you give as-is. But if you specify delay=1 (floor(100/60)), it'll mean 100fps, and browsers will ignore it. So you must clamp fps to 50 to make sure you get delay=2. |
|
Done. I've confirmed that the delay is |
Closed
|
My slider only goes up to 30 fps for some reason |
|
Is the video 60 FPS? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
@kornelski If the user sets 60 FPS, it will just use 50 FPS, right? Or do I need to clamp the actual value passed to gifski-lib at 50 FPS?