fixing the base64 garbage processing #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
May 20, 2025
anonrig
reviewed
May 21, 2025
|
|
||
| simdutf_really_inline const char *find(const char *start, const char *end, | ||
| char character) noexcept { | ||
| for (; std::distance(start, end) >= 64; start += 64) { |
There was a problem hiding this comment.
FYI: Std::distance has a O(N) complexity avoid calling it will improve performance.
There was a problem hiding this comment.
I believe that, in this instance, it is constant time because a pointer is a "LegacyRandomAccessIterator".
https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator
I believe that it is even applies to cases like this...
std::vector<X> v =....
return std::distance(v.begin(), v.end());It is possible that an alternative coding could improve performance in some cases. I am not sure.
pauldreik
reviewed
May 23, 2025
added 2 commits
May 23, 2025 22:57
|
I am going to merge. Thanks @anonrig and @pauldreik for the review. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention is Node.js is that lenient processing stops with the first '=' character. Thus we have
The current fix is suboptimal: I look for the first occurence of
=using std::find. We should roll our own fast 'find' function.I have coded a fast find function for some kernels.
Fixes #792
Fixes #795